Fix Dependabot MSAL package upgrade by updating compatible versions #2632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: pamelafox <[email protected]>
Copilot
AI
changed the title
Copilot finished work on behalf of
pamelafox
July 28, 2025 16:42
pamelafox
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the CI failure in Dependabot PR #2627 by properly upgrading both
@azure/msal-browserand@azure/msal-reactto compatible versions.Problem
The original Dependabot PR failed because it attempted to upgrade
@azure/msal-browserfrom^3.26.1to^4.16.0without updating the dependent@azure/msal-reactpackage. This created a peer dependency conflict since@azure/[email protected]requires@azure/msal-browser@^3.27.0, but the upgrade tried to install@azure/[email protected].Solution
Updated both packages to their latest compatible versions:
@azure/msal-browser:^3.26.1→^4.16.0(latest)@azure/msal-react:^2.2.0→^3.0.16(latest, supports@azure/msal-browser@^4.16.0)Testing
npm run build)Verification
The Python dependency error mentioned in the original issue description appears to have been a red herring or secondary issue, as the current Python dependencies (
requests==2.32.4,urllib3==2.5.0) are fully compatible.Fixes #2631.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
openaipublic.blob.core.windows.net/home/REDACTED/work/azure-search-openai-demo/azure-search-openai-demo/.venv/bin/python /home/REDACTED/work/azure-search-openai-demo/azure-search-openai-demo/.venv/bin/pytest -s -vv --cov --cov-fail-under=89(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.